I also use 1Password. I've been using it for many years across platforms. I currently have about 1500 items in it. Here are my pros and cons:
Pros:
Cloud based with encryption - Probably as good as you will get aside from keeping data locally.
Web based interface - Useful if you are on someone else's device or shared computer.
Multi-client - Native client for Mac, Win, IOS, Android and of course a web browser. Opens with fingerprint on IOS.
Good track record of data availability - Cannot recall experiencing any service outage.
Personal and family versions - You can selectively share certain passwords with others.
Many different item types - login, software license, bank account, email, document (currently 18 different)
Password generator easy to use and it remembers your old passwords automatically when you update
Free trial period
Cons:
Revenue model has moved from 'perpetual with annual support fee' to a 'monthly or yearly subscription' ($36 - $60/yr). So now it represents an ongoing monthly expense for me.
Takes a bit of effort to set it up including logging in with a long key that they initially give you along with your master password on each device you own. Adding additional users is also a bit tedious.
Has ability to capture passwords you use on web but that sometimes can create multiple entries for same website.